fix overriding a disabled model in a package #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Apr 20, 2017
dbt/parser.py
Outdated
| flat_graph, | ||
| target_model_name, | ||
| target_model_package) | ||
| # first, look for a model that matches the current |
There was a problem hiding this comment.
@cmcarthur I'm kind of surprised this works! I think the ref resolution order we want is:
- "top-level" project
- The node's package
- All packages
Does that seem right to you?
There was a problem hiding this comment.
That precedence seems sane to me. I'll update this. The use case here is that a model in a package uses {{ref('dep')}} and then you can override dep in your project, right?
This also doesn't work quite right as I think more about it -- what you want is to continue to the next option if the one you found is disabled. @drewbanin if you have time this afternoon let's discuss
drewbanin
approved these changes
Apr 20, 2017
added 2 commits
April 20, 2017 19:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drewbanin this adds a test & fix for overriding a disabled model from a package in the current project