Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] dbt_expectations <0.9.0 dependency #44

Closed
2 of 4 tasks
raphaelvarieras opened this issue Aug 30, 2023 · 8 comments
Closed
2 of 4 tasks

[Bug] dbt_expectations <0.9.0 dependency #44

raphaelvarieras opened this issue Aug 30, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers type:enhancement New functionality or enhancement update_type:dependency Primary focus is to update dependencies

Comments

@raphaelvarieras
Copy link

raphaelvarieras commented Aug 30, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

The latest version out of dbt-expectations is 0.9.0 and this package forces us to pin to an older version.

Relevant error log or model output

N/A

Expected behavior

Update the package to support 0.9.0

dbt Project configurations

N/A

Package versions

N/A

What database are you using dbt with?

snowflake

dbt Version

1.6

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-jamie fivetran-jamie added good first issue Good for newcomers status:accepted Scoped and accepted into queue update_type:dependency Primary focus is to update dependencies labels Sep 1, 2023
@fivetran-jamie
Copy link
Collaborator

Hi there @raphaelvarieras, thanks for opening this issue!

I just tested the Google Ads packages out locally with v0.9.0 of dbt-expectations, and everything seems to work smoothly! Don't think we'll need to update anything other than the packages.yml.

The team and I will get slot this in for our next sprint and just validate that there aren't any unintended consequences in our downstream Ad Reporting models

@fivetran-reneeli
Copy link
Contributor

Thanks @raphaelvarieras for raising this! This has been included in our most recent release.

@fivetran-reneeli
Copy link
Contributor

Never mind, taking that back. We didn't realize this was cause errors for those using our other packages that are also on the older version of dbt expectations. So we will be rolling this out universally instead. But in the meantime we will roll back this change

@jstingey
Copy link

@fivetran-reneeli imports of fivetran/ad_reporting is still failing dbt deps with the incompatible versions for dbt_expectations.

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Sep 18, 2023

Hi @jstingey can you confirm if this failure is still occurring?

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement and removed type:bug Something is broken or incorrect labels Sep 19, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

For all following this thread - Our team will be working on making this update in our current sprint and will be making this a breaking change for the google (and downstream) packages so we may avoid dependency errors that were previously encountered by users.

We apologize for the failures that were caused as a result of the previous release and appreciate all of you working with us to correct the issue and forge a path forward for a better result to come with no unforeseen dependency errors.

@fivetran-reneeli fivetran-reneeli mentioned this issue Sep 22, 2023
17 tasks
@fivetran-reneeli
Copy link
Contributor

Hi all, thanks for your patience! The updates will be provided in our next release in the following week.

@fivetran-catfritz
Copy link
Contributor

This feature has been added to v0.10.0 and released today! Closing out this issue, but please continue to let us know any feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:enhancement New functionality or enhancement update_type:dependency Primary focus is to update dependencies
Projects
None yet
Development

No branches or pull requests

6 participants