Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point clouds are calculated by disparity. Why are point clouds in ladder shape? #46

Closed
8BitCatJQW opened this issue Aug 19, 2019 · 8 comments

Comments

@8BitCatJQW
Copy link

No description provided.

@NiuKeke
Copy link

NiuKeke commented Aug 20, 2019

No description provided.
Maybe you have forgotten the subpixel param which you should have set true.

@8BitCatJQW
Copy link
Author

No description provided.
Maybe you have forgotten the subpixel param which you should have set true.
Thank you for your reply
Here are my Settings, but still with the same problem.
struct Parameters
{
int P1;
int P2;
float uniqueness;
bool subpixel;
Parameters(int P1 = 10, int P2 = 120, float uniqueness = 0.95f, bool subpixel = true) : P1(P1), P2(P2), uniqueness(uniqueness), subpixel(subpixel) {}
};

@sotsuka-fixstars
Copy link
Contributor

sotsuka-fixstars commented Aug 20, 2019

Hi, @8BitCatJQW
Thank you for using libSGM.

Where was this issue occurred in? Our sample or your repository?
We would apprecite if you tell us more details.

@8BitCatJQW
Copy link
Author

Hi, @8BitCatJQW
Thank you for using libSGM.
Where was this issue occurred in? Our sample or your repository?
We would apprecite if you tell us more details.
Thank you for your reply。
This is my repository:https://github.com/8BitCatJQW/libsgmIssueDetails
Can you tell me your E-mail?I can send you the results of my experiment.

@sotsuka-fixstars
Copy link
Contributor

As 8BitCatJQW/libsgmIssueDetails#1 was merged, I will close this issue.
If you are faced with anything related this issue, reopen it.

@8BitCatJQW
Copy link
Author

As 8BitCatJQW/libsgmIssueDetails#1 was merged, I will close this issue.
If you are faced with anything related this issue, reopen it.

ok Thank you very much. It's my fault.

@DekaiZhu
Copy link

@sotsuka-fixstars hi, thanks for your code! i use your code to calculate the disparity map from a pair of images from a stereo vision system, and then i use this disparity map to calculate the point cloud but i meet some problem. I am sure that i have enabled the sub-pixel mode (which means that 4 bits in the output disparity value are used for fractional part), but the plane in the generated point cloud still looks like a ladder.
2020-09-22 09-39-09屏幕截图
I have tried to compute the mean value with several depth maps, but this small ladder is still there, so i wanna know if there are some suitable method to reduce this problem :)

@sotsuka-fixstars
Copy link
Contributor

Hi, @DekaiZhu,

a pair of images from a stereo vision system,

Thank you for finding weakness of libSGM.
If you don't mind, could you share test dataset?
We would like to check it as well.

May be post disparity refinement were needed.
Comparisons are following link.

#20 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants