From c5606dc3ce2037adec79df89dedbe3647ad25e2e Mon Sep 17 00:00:00 2001 From: Davide Iadeluca Date: Sat, 19 Oct 2024 19:03:34 +0200 Subject: [PATCH 1/4] chore: update frontend workflow Backport of https://github.com/flarum/framework/commit/356f97641ed8d087dd1252e4cc2180484d8590cd --- .github/workflows/REUSABLE_frontend.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/REUSABLE_frontend.yml b/.github/workflows/REUSABLE_frontend.yml index f6a9d7d1bb..27f91753d4 100644 --- a/.github/workflows/REUSABLE_frontend.yml +++ b/.github/workflows/REUSABLE_frontend.yml @@ -116,10 +116,10 @@ jobs: steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Set up Node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ inputs.node_version }} cache: ${{ inputs.js_package_manager }} From fc144a64eda445b455f61704b6788003f18eac44 Mon Sep 17 00:00:00 2001 From: Davide Iadeluca Date: Sat, 19 Oct 2024 19:18:33 +0200 Subject: [PATCH 2/4] chore: bump default node version and `flarum/action-build` --- .github/workflows/REUSABLE_frontend.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/REUSABLE_frontend.yml b/.github/workflows/REUSABLE_frontend.yml index 27f91753d4..31a30d5ddc 100644 --- a/.github/workflows/REUSABLE_frontend.yml +++ b/.github/workflows/REUSABLE_frontend.yml @@ -74,7 +74,7 @@ on: description: The node version to use for the workflow. type: number required: false - default: 16 + default: 20 js_package_manager: description: "Enable TypeScript?" @@ -142,7 +142,7 @@ jobs: working-directory: ${{ inputs.frontend_directory }} - name: JS Checks & Production Build - uses: flarum/action-build@v3 + uses: flarum/action-build@v4 with: github_token: ${{ secrets.GITHUB_TOKEN }} build_script: ${{ inputs.build_script }} From 6dbf5a567aaf3a13b6bffda0bd3c1d62fcd0fa54 Mon Sep 17 00:00:00 2001 From: Davide Iadeluca Date: Sat, 19 Oct 2024 22:40:07 +0200 Subject: [PATCH 3/4] fix --- .github/workflows/REUSABLE_frontend.yml | 1 + js-packages/tsconfig/tsconfig.json | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/REUSABLE_frontend.yml b/.github/workflows/REUSABLE_frontend.yml index 31a30d5ddc..dbb5988fdb 100644 --- a/.github/workflows/REUSABLE_frontend.yml +++ b/.github/workflows/REUSABLE_frontend.yml @@ -105,6 +105,7 @@ env: ci_script: ${{ inputs.js_package_manager == 'yarn' && 'yarn install --immutable' || 'npm ci' }} cache_dependency_path: ${{ inputs.cache_dependency_path || format(inputs.js_package_manager == 'yarn' && '{0}/yarn.lock' || '{0}/package-lock.json', inputs.frontend_directory) }} COMPOSER_AUTH: ${{ secrets.composer_auth }} + DISABLE_V8_COMPILE_CACHE: 1 jobs: build: diff --git a/js-packages/tsconfig/tsconfig.json b/js-packages/tsconfig/tsconfig.json index 92bc9ec883..7ad380af48 100644 --- a/js-packages/tsconfig/tsconfig.json +++ b/js-packages/tsconfig/tsconfig.json @@ -1,5 +1,6 @@ { "compilerOptions": { + "skipLibCheck": true, "allowUmdGlobalAccess": true, "sourceMap": true, "strict": true, From 02afc84dc757316d177cf39459abd7ecf0ad34bc Mon Sep 17 00:00:00 2001 From: Davide Iadeluca Date: Sat, 19 Oct 2024 22:45:22 +0200 Subject: [PATCH 4/4] dummy commit