From bd752f2479c9763a4d98f9b59621f3cfadd2662f Mon Sep 17 00:00:00 2001
From: Joe Reuter <email@johannes-reuter.de>
Date: Thu, 14 Feb 2019 11:34:10 +0100
Subject: [PATCH] Fix management footer logo spacing bug (#30654)

---
 .../sections/settings/advanced_settings.scss  | 10 ++++++
 .../field/__snapshots__/field.test.js.snap    | 32 +++++++++++++++++++
 .../settings/components/field/field.js        |  1 +
 3 files changed, 43 insertions(+)

diff --git a/src/legacy/core_plugins/kibana/public/management/sections/settings/advanced_settings.scss b/src/legacy/core_plugins/kibana/public/management/sections/settings/advanced_settings.scss
index b81c17dd8f3a3..6710583cf5c87 100644
--- a/src/legacy/core_plugins/kibana/public/management/sections/settings/advanced_settings.scss
+++ b/src/legacy/core_plugins/kibana/public/management/sections/settings/advanced_settings.scss
@@ -5,9 +5,19 @@
 
   &Wrapper {
     width: 640px;
+
+    @include internetExplorerOnly() {
+      min-height: 1px;
+    }
   }
 
   &Actions {
     padding-top: $euiSizeM;
   }
+
+  @include internetExplorerOnly {
+    &Row {
+      min-height: 1px;
+    }
+  }
 }
diff --git a/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap b/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap
index f92a9d9209396..9c4455f26ac51 100644
--- a/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap
+++ b/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap
@@ -63,6 +63,7 @@ exports[`Field for array setting should render as read only with help text if ov
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "array:test:setting-aria",
@@ -158,6 +159,7 @@ exports[`Field for array setting should render custom setting icon if it is cust
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "array:test:setting-aria",
@@ -231,6 +233,7 @@ exports[`Field for array setting should render default value if there is no user
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "array:test:setting-aria",
@@ -327,6 +330,7 @@ exports[`Field for array setting should render user value if there is user value
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "array:test:setting-aria",
@@ -442,6 +446,7 @@ exports[`Field for boolean setting should render as read only with help text if
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "boolean:test:setting-aria",
@@ -541,6 +546,7 @@ exports[`Field for boolean setting should render custom setting icon if it is cu
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "boolean:test:setting-aria",
@@ -618,6 +624,7 @@ exports[`Field for boolean setting should render default value if there is no us
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "boolean:test:setting-aria",
@@ -718,6 +725,7 @@ exports[`Field for boolean setting should render user value if there is user val
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "boolean:test:setting-aria",
@@ -837,6 +845,7 @@ exports[`Field for image setting should render as read only with help text if ov
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "image:test:setting-aria",
@@ -929,6 +938,7 @@ exports[`Field for image setting should render custom setting icon if it is cust
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "image:test:setting-aria",
@@ -1000,6 +1010,7 @@ exports[`Field for image setting should render default value if there is no user
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "image:test:setting-aria",
@@ -1094,6 +1105,7 @@ exports[`Field for image setting should render user value if there is user value
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "image:test:setting-aria",
@@ -1225,6 +1237,7 @@ exports[`Field for json setting should render as read only with help text if ove
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "json:test:setting-aria",
@@ -1336,6 +1349,7 @@ exports[`Field for json setting should render custom setting icon if it is custo
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "json:test:setting-aria",
@@ -1452,6 +1466,7 @@ exports[`Field for json setting should render default value if there is no user
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "json:test:setting-aria",
@@ -1587,6 +1602,7 @@ exports[`Field for json setting should render user value if there is user value
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "json:test:setting-aria",
@@ -1718,6 +1734,7 @@ exports[`Field for markdown setting should render as read only with help text if
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "markdown:test:setting-aria",
@@ -1829,6 +1846,7 @@ exports[`Field for markdown setting should render custom setting icon if it is c
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "markdown:test:setting-aria",
@@ -1918,6 +1936,7 @@ exports[`Field for markdown setting should render default value if there is no u
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "markdown:test:setting-aria",
@@ -2030,6 +2049,7 @@ exports[`Field for markdown setting should render user value if there is user va
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "markdown:test:setting-aria",
@@ -2161,6 +2181,7 @@ exports[`Field for number setting should render as read only with help text if o
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "number:test:setting-aria",
@@ -2256,6 +2277,7 @@ exports[`Field for number setting should render custom setting icon if it is cus
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "number:test:setting-aria",
@@ -2329,6 +2351,7 @@ exports[`Field for number setting should render default value if there is no use
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "number:test:setting-aria",
@@ -2425,6 +2448,7 @@ exports[`Field for number setting should render user value if there is user valu
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "number:test:setting-aria",
@@ -2540,6 +2564,7 @@ exports[`Field for select setting should render as read only with help text if o
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "select:test:setting-aria",
@@ -2652,6 +2677,7 @@ exports[`Field for select setting should render custom setting icon if it is cus
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "select:test:setting-aria",
@@ -2742,6 +2768,7 @@ exports[`Field for select setting should render default value if there is no use
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "select:test:setting-aria",
@@ -2855,6 +2882,7 @@ exports[`Field for select setting should render user value if there is user valu
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "select:test:setting-aria",
@@ -2987,6 +3015,7 @@ exports[`Field for string setting should render as read only with help text if o
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "string:test:setting-aria",
@@ -3082,6 +3111,7 @@ exports[`Field for string setting should render custom setting icon if it is cus
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "string:test:setting-aria",
@@ -3155,6 +3185,7 @@ exports[`Field for string setting should render default value if there is no use
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "string:test:setting-aria",
@@ -3251,6 +3282,7 @@ exports[`Field for string setting should render user value if there is user valu
       titleSize="xs"
     >
       <EuiFormRow
+        className="mgtAdvancedSettings__fieldRow"
         describedByIds={
           Array [
             "string:test:setting-aria",
diff --git a/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js b/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
index 2d87ca4f69163..2139a842f639d 100644
--- a/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
+++ b/src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
@@ -721,6 +721,7 @@ class FieldUI extends PureComponent {
               label={this.renderLabel(setting)}
               helpText={this.renderHelpText(setting)}
               describedByIds={[`${setting.name}-aria`]}
+              className="mgtAdvancedSettings__fieldRow"
             >
               {this.renderField(setting)}
             </EuiFormRow>