Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted punk bid acceptance transaction causes exception in punk snipe processing #329

Open
pintail-xyz opened this issue Feb 15, 2023 · 0 comments

Comments

@pintail-xyz
Copy link
Contributor

pintail-xyz commented Feb 15, 2023

Processing for block 13690822 currently fails with a database error due to attempted insertion of a duplicate "punk snipe". The reason for this appears to be that block 13690822 contains two "bid acceptance" transactions for punk 5807. The second of these transactions was reverted (the previous owner can't double spend their punk), however mev-inspect-py treats the reverted acceptance as a separate sniped punk sale, resulting in a duplicate punk snipe.

Reverted transactions bid acceptance transactions should instead be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant