Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude profiles/repo_name when syncing with Gentoo #158

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Jul 16, 2024

Exclude profiles/repo_name when syncing with Gentoo

We want to call our own repo portage-stable (or soon gentoo-subset) so stop setting this file back to "gentoo". It wasn't an issue before because we set the name to portage-stable in layout.conf, but you're not supposed to set it there anymore.

The change achieves this with rsync, which also gives the benefit of less disk churn.

I did consider doing this exclusion via portage-stable-packages-list, but one line is passed to sync-with-gentoo at a time, which doesn't really allow for exclusions. sync-with-gentoo already has specific rules for certain directories, so this doesn't seem so bad.

How to use

Try it as usual and see whether repo_name changes.

Testing done

I have manually run sync-with-gentoo locally to see the effect on repo_name and other files.

@chewi chewi requested a review from a team July 16, 2024 13:29
@chewi chewi changed the title Exclude profiles/repo_name when syncing with Gentoo WIP Exclude profiles/repo_name when syncing with Gentoo Jul 16, 2024
chewi added 2 commits July 16, 2024 15:44
This has less disk churn and allows us to exclude certain files.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
We want to call our own repo portage-stable (or soon gentoo-subset) so
stop setting this file back to "gentoo". It wasn't an issue before
because we set the name to portage-stable in layout.conf, but you're not
supposed to set it there any more.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@chewi chewi force-pushed the chewi/exclude-repo-name branch from 4d773b3 to 22eec64 Compare July 16, 2024 14:52
It was failing due to set -u.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@chewi chewi changed the title WIP Exclude profiles/repo_name when syncing with Gentoo Exclude profiles/repo_name when syncing with Gentoo Jul 16, 2024
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what it gives on the weekly update on Monday. Thanks!

@chewi chewi merged commit 6495dd7 into master Jul 19, 2024
@chewi chewi deleted the chewi/exclude-repo-name branch July 19, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants