Migrate release AMI gc to ci-automation #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deletion of old release AMIs was still relying on the previous Jenkins setup. Move this to the ci-automation folder.
krnowak
approved these changes
Apr 24, 2024
| @@ -256,6 +256,7 @@ function _garbage_collect_impl() { | |||
| docker run --pull always --rm --net host \ | |||
| --env AZURE_AUTH_CREDENTIALS --env AZURE_PROFILE \ | |||
| --env AWS_ACCESS_KEY_ID --env AWS_SECRET_ACCESS_KEY \ | |||
| --env AWS_CREDENTIALS \ | |||
There was a problem hiding this comment.
I suppose that these are yet different stuff from AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY?
There was a problem hiding this comment.
I think yes, the test and release credentials are different
There was a problem hiding this comment.
We probably could just drop this whole directory, no?
There was a problem hiding this comment.
We would have to migrate the jenkins/systemd-run-wrap.sh script which is used by jenkins-os/container/ but otherwise yes, possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deletion of old release AMIs was still relying on the previous Jenkins setup. Move this to the ci-automation folder.
How to use
Testing done
It worked on a manual run in Jenkins:
Pruning complete: {total:508 kept:42 skipped:420 recentlyUsed:4 softDeleted:42 deleted:0}and similar showed up 8 times.