-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: Add Flatcar extensions to vm-images artifact #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Flatcar extensions get built by the GitHub PR CI but only their content files get archived. Add the .raw image itself so that one can copy it into the image (downloading it at boot time won't work because this uses bincache - so one could get an extension image in case the but version happens to match but it won't be the one that was built in the GitHub CI).
chewi
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flatcar extensions get built by the GitHub PR CI but only their content files get archived. Add the .raw image itself so that one can copy it into the image (downloading it at boot time won't work because this uses bincache - so one could get an extension image in case the but version happens to match but it won't be the one that was built in the GitHub CI).
How to use
For testing PRs like #1964
Testing done
Checked that
flatcar-zfs.raw
is part ofamd64-vm-images.zip