app-crypt/efitools: Drop in favour of app-emulation/virt-firmware #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it pulls in a number of dependencies. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
virt-fw-vars handles X.509 conversion and QCOW2 conversion transparently and can update all the variables in a single invocation. Bonus: Asking it to list the variables doesn't cause a segfault due to the feature not really being implemented. :D The 00000000-0000-0000-0000-000000000000 owner GUID is what flash-var used to set, as we didn't specify the -g argument. We don't need to set a meaningful value as this file is only for testing. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
tormath1
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace efitools with virt-firmware
virt-fw-vars handles X.509 conversion and QCOW2 conversion transparently and can update all the variables in a single invocation.
Bonus: Asking it to list the variables doesn't cause a segfault due to the feature not really being implemented. 😁
The 00000000-0000-0000-0000-000000000000 owner GUID is what flash-var used to set, as we didn't specify the
-gargument. We don't need to set a meaningful value as this file is only for testing.How to use
Simply use
./flatcar_production_qemu_uefi_secure.sh -T swtpmto ensure the image still works with Secure Boot enabled.Testing done
qemu_uefi_secure failed overall but only because of
cl.tpm.eventlog, which was already failing.changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc. -- N/A