This requires at least appstreamcli>=0.16.3 in meson.build.

I think it is fine, partials URLs when a baseurl is supplied doesn't make sense. The spec says icon/image should start with http(s)

Should fix #573

I don't think this fixes that issue? --no-partial-urls does not change the location of screenshots, they are still in share/app-info/media. The expectation there is, builddir/screenshots (it's not that flatpak-builder does not create screenshot dir, but it changed the previous location)

This fixes a problem we would experience in the Flathub backend, and --no-partial-urls was added per our request.

This requires at least appstreamcli>=0.16.3 in meson.build.

I think this is all that's needed to land this.

../meson.build:44:15: ERROR: Invalid version of program, need 'appstreamcli' ['>= 0.16.3'] found '0.16.1'.

I guess building on fedora 38 is a no go.

Also it's a runtime dependency while this is a meson (build-time) check.

done, but I don't think it will build in CI

On CI:

Program appstreamcli found: NO found 0.15.2 but need: '>= 0.16.3' (/usr/bin/appstreamcli)

Ubuntu 23.10 has 0.16.2... how annoying.

Ubuntu folks clarified that it's unlikely they'll ever update the appstream package, so either the Ubuntu workflows are dropped, or updated to a non-LTS version

I'll reset the checks in meson and check at runtime in some way. Using CLI as an API...

And this, in turn, explodes with this:

Unable to set icon policy: 64x64@1 icons were not selected for being cached, which is not permitted.

so I'm dropping it after all

The approach here would be to degrade if the version of appstream is too low. But the check is a bit too hackish.

Checking in meson.build is kind of irrelevant since it's build time.