Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have CI that builds with --wrap-mode=nodownload #594

Open
2 tasks done
nanonyme opened this issue Mar 25, 2024 · 1 comment
Open
2 tasks done

Have CI that builds with --wrap-mode=nodownload #594

nanonyme opened this issue Mar 25, 2024 · 1 comment

Comments

@nanonyme
Copy link
Contributor

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Suggestion

Currently this project builds with submodules. But when submodules are broken, Meson automatically switches to wraps. Let's have two CI modes from Meson

  1. submodules are disabled. We test that wraps work
  2. submodules are enabled but --wrap-mode=nodownload is passed. if submodules don't work, then build fails
@nanonyme
Copy link
Contributor Author

nanonyme commented Mar 25, 2024 •
edited
Loading

@TingPing this might be material for after autotools is removed. I think this is why CI didn't break when submodule was incorrectly updated last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nanonyme