Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak-builder silently ignores entries of invalid type in build-commands in manifest YAML #602

Open
2 tasks done
nandedamana opened this issue May 20, 2024 · 1 comment

Comments

@nandedamana
Copy link
Contributor

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.15.6

Flatpak version

1.4.1

How to reproduce

  1. Start a sample flatpak project with a YAML manifest, simple build method, and multiple commands listed under build-commands as an array; make sure the build succeeds
  2. Add false as an element in the build-commands array somewhere in the middle (simulating a user adding it meaning the UNIX false command, without realizing it should've been quoted)

Expected Behavior

flatpak-builder should warn that the list contains an element of invalid type (bool instead of string).

Actual Behavior

flatpak-builder silently ignores the bool entry and finishes the build successfully.

Additional Information

No response

@nandedamana
Copy link
Contributor Author

The issue could be with json_gobject_deserialize().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant