Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name/file conflicts megathread #163

Open
flazz opened this issue Feb 24, 2019 · 3 comments
Open

name/file conflicts megathread #163

flazz opened this issue Feb 24, 2019 · 3 comments

Comments

@flazz
Copy link
Owner

flazz commented Feb 24, 2019

Hey all, first of all, thanks for the patience. There seems to be a large set of issues that revolves around the filename conflicting with some internal value or vim feature.

I think biggest challenge is that there are many flavors of this issue and many flavors of proposed solutions. Solving one issue may conflict with solving another.

Instead of modifying the scheme files to for any specific situation we start sharing a set of opt-in scripts to fix these things locally.

If any convergence happens we can work towards a better general case solution; if things stay diverged no harm done, the impact is a set of scripts and words in the readme. Thoughts?

@peara
Copy link

peara commented Feb 27, 2019

Hi, the issue with conflicting name was when I set color scheme to one with a wrongly name (different with its file or same as another's). Next time when vim starts up, it will take the wrong one, or cannot find any. So I guess it must be fixed. At least the name of the scheme and the file contains it must be the same.

@Knio
Copy link

Knio commented Feb 28, 2019

I'm very 👎 on scripts and additional instructions. The files should simply work as advertised out of the box.

I'm not an expert or even a mediocre user of vim to even be sure if I understand the issue, so someone else can please correct me, but it seems like the file name on the filesystem has the match the scheme name declared inside the file. So it's a pretty simple two choices: either rename the file, or rename the scheme (or both, as long as they match, or tell me I misunderstood the issue). I have no opinion on which solution is chosen, or how these files or names came to be.

@chris-roerig
Copy link
Contributor

My vote is for convention over configuration. Renaming all existing themes to lowercase and then only accepting lowercase themes after that would solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants