fix: fixed multiple issues in PolygonLayer and PolylineLayer
#1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `useDynamicUpdate`
… as the `Polygon.points` would not be cut out
…ationManagementSupportedWidget`
mootw
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
looks good. I think we should just remove the value outright and cause a break. given the feature shipped broken, i only see depreciating it as changing its behavior unexpectedly anyways since it does not do anything anymore. and removing the value will alert anyone who was using the broken feature to fix it.
ill personally handle any issues related to this break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924, fixes #1921, fixes #1912, fixes #1913.
Effectively reverts some broken commits.
Note that
useDynamicUpdatehas been deprecated, but its functionality has changed - it now has no purpose. However, this will not be a breaking change, asuseDynamicUpdatewas broken when initially introduced, so there should be no legitimate users.