From 41fe5461f432266afe75c7cd183aae27306c7c08 Mon Sep 17 00:00:00 2001 From: Jason Newcomb Date: Mon, 20 Sep 2021 12:50:59 -0400 Subject: [PATCH] Retry on some download errors in lintcheck --- lintcheck/src/main.rs | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/lintcheck/src/main.rs b/lintcheck/src/main.rs index f1e03ba42966d..97d3794fb84f0 100644 --- a/lintcheck/src/main.rs +++ b/lintcheck/src/main.rs @@ -15,6 +15,8 @@ use std::{ env, fmt, fs::write, path::{Path, PathBuf}, + thread, + time::Duration, }; use clap::{App, Arg, ArgMatches}; @@ -109,6 +111,22 @@ impl std::fmt::Display for ClippyWarning { } } +fn get(path: &str) -> Result { + const MAX_RETRIES: u8 = 4; + let mut retries = 0; + loop { + match ureq::get(path).call() { + Ok(res) => return Ok(res), + Err(e) if retries >= MAX_RETRIES => return Err(e), + Err(ureq::Error::Transport(e)) => eprintln!("Error: {}", e), + Err(e) => return Err(e), + } + eprintln!("retrying in {} seconds...", retries); + thread::sleep(Duration::from_secs(retries as u64)); + retries += 1; + } +} + impl CrateSource { /// Makes the sources available on the disk for clippy to check. /// Clones a git repo and checks out the specified commit or downloads a crate from crates.io or @@ -129,7 +147,7 @@ impl CrateSource { if !krate_file_path.is_file() { // create a file path to download and write the crate data into let mut krate_dest = std::fs::File::create(&krate_file_path).unwrap(); - let mut krate_req = ureq::get(&url).call().unwrap().into_reader(); + let mut krate_req = get(&url).unwrap().into_reader(); // copy the crate into the file std::io::copy(&mut krate_req, &mut krate_dest).unwrap();