Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid path errors while deploying SDK by enforcing toolchain to use UTF-8 on initial SDK Extraction #4036

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Fix invalid path errors while deploying SDK by enforcing toolchain to use UTF-8 on initial SDK Extraction #4036

merged 3 commits into from
Dec 23, 2024

Conversation

Alex4386
Copy link
Contributor

@Alex4386 Alex4386 commented Dec 16, 2024 •
edited by skotopes
Loading

What's new

Verification

  • The System.IO.Compression.ZipFile::ExtractToDirectory will have UTF-8 Encoding enforced.
  • The Current SDK will successfully deploy on OS environments that has non-cryillic or non-latin coding pages by default

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Alex4386 Alex4386 mentioned this pull request Dec 16, 2024
Closed
@Alex4386 Alex4386 changed the title Fix invalid path errors for non-Latin characters by enforcing UTF-8 encoding in toolchain Fix invalid path errors while deploying SDK by enforcing toolchain to use UTF-8 on initial SDK Extraction Dec 17, 2024
@Alex4386
Fix invalid path errors for non-Latin characters by enforcing UTF-8 (f…
76a7183 
…lipperdevices#4024)

Due to cryillic alphabet on `/openocd/scripts/target/1986ве1т.cfg`, If the system codepage is handling `WideChar` for cryillic properly, It would cause jumbled characters and fail to decompress via System.IO.Compression.ZipFile without Encoding enforcement. (See flipperdevices#4024 (comment))
@Alex4386 Alex4386 force-pushed the feature/enforce-toolchain-utf8 branch from 9e2afb4 to 76a7183 Compare December 17, 2024 04:09
@skotopes
Copy link
Member

Nice catch. Thanks for finding and fixing issue.

@skotopes skotopes merged commit 519b896 into flipperdevices:dev Dec 23, 2024
11 checks passed
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Dec 23, 2024
@Alex4386 @skotopes @RogueMaster
Fix invalid path errors while deploying SDK by enforcing toolchain to…
4832640 
… use UTF-8 on initial SDK Extraction (flipperdevices#4036)

* Fix invalid path errors for non-Latin characters by enforcing UTF-8 (flipperdevices#4024)
  Due to cryillic alphabet on `/openocd/scripts/target/1986ве1т.cfg`, If the system codepage is handling `WideChar` for cryillic properly, It would cause jumbled characters and fail to decompress via System.IO.Compression.ZipFile without Encoding enforcement. (See flipperdevices#4024 (comment))
* Scripts: fix line endings

Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ufbt no longer properly deploys SDK on Windows Systems with non-Latin/Cyrillic system language
2 participants
@Alex4386 @skotopes