Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Sync from Brave Browser on 3 PCs all with v4.19.0 #1364

Closed
1 task done
dsiminiuk opened this issue Mar 28, 2023 · 21 comments
Closed
1 task done

No Sync from Brave Browser on 3 PCs all with v4.19.0 #1364

dsiminiuk opened this issue Mar 28, 2023 · 21 comments
Labels

Comments

@dsiminiuk
Copy link

Which version of floccus are you using?

4.19.0

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Brave

Which version of Nextcloud Bookmarks are you using? (if relevant)

12.1.0

Which version of Nextcloud? (if relevant)

25.0.5

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

No sync up or down even when I add or remove bookmarks from the NC Booksmarks app. I've uninstalled, reinstalled, no differnce.

Expected Behavior

It should sync like it used to.

To Reproduce

Click the Floccus add-in button and sync, push up or push down, no sync. One laptop with Brave now shows "Disabled". ???

Debug log provided

  • I have provided a debug log file
@dsiminiuk dsiminiuk added the bug label Mar 28, 2023
@dsiminiuk
Copy link
Author

dsiminiuk commented Mar 28, 2023

I reverted to v4.18.1 and it works fine again on the laptop that was "Disabled". OK Disabled just means Auto-sync is off.

And it gets worse for Brave on Windows. Because v4.18.1 is no longer on the Chrome Webstore you can't even install the crx file of the previous version in the Extensions page with Developer mode on.
2 PCs on Linux with brave are now working.
2 Windows PCs are disconnected from my NC Bookmarks with no floccus extension.

@eihnat
Copy link

eihnat commented Mar 28, 2023

same issue here. reverting back to v4.18.1 solved and sync works.

@BOFH90
Copy link

BOFH90 commented Mar 28, 2023

Same issue on macOS and Windows with Nextcloud, Brave and v4.19.0

@baritell
Copy link

baritell commented Mar 28, 2023

Wanted to chime in here in case this might help.
I first noticed 4.19 was not working for me on a new windows box when I tried to run my first pull. It showed success and the logs had all my bookmarks but nothing showed up on the Chrome or Firefox "Toolbar".
I then tested a bit on my linux box via Chrome and Firefox and found something odd. If I already have a folder on the root of the bookmarks toolbar I can add and delete bookmarks and it works as expected. However, If I try to add or remove anything from the root of the toolbar it is not working.
Hope that might help someone who knows more than me. Thanks
I should add that I am also using the nextcloud bookmarks currently on version 13.0.1. Nextcloud version: 26.0.0.11
floccus-4.19.0-2023-03-28.log

@dsiminiuk
Copy link
Author

@baritell Agreed! I played with 4.19.0 some more on Windows and it does work for bookmarks in folders below the Bookmark Bar but not for changes on the bookmark bar. Good find!

@marcelklehr
Copy link
Member

Thanks for reporting this. I have a fix in mind but don't know when I'll get to applying and releasing it. Fingers crossed

@dsiminiuk
Copy link
Author

dsiminiuk commented Mar 28, 2023

@marcelklehr

Just confirmed on Windows 10, Brave Browser and floccus 4.19.0 - when adding a new bookmark to the bookmark bar, it does not upload it to the server. Move the same bookmark to a folder and voila!

Delete the bookmark from the folder on the server, re-sync, and it is removed from the client end also.

@cimenta
Copy link

cimenta commented Mar 29, 2023

same issue here. reverting back to v4.18.1 solved and sync works.

could you please provide steps how to revert?

I downloaded crx file of v4.18.1 file from https://github.com/floccusaddon/floccus/releases but got this error https://i.imgur.com/z3QivOo.png

@eihnat
Copy link

eihnat commented Mar 29, 2023

Managed to do this only in Firefox.
https://addons.mozilla.org/en-US/firefox/addon/floccus/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search
on extension page there's on left lower side "see all versions" and you can pick which one you want. you need to uninstall newer one first i think.
Didn't find how to do it on Brave (Chrome probably same).

@dsiminiuk
Copy link
Author

dsiminiuk commented Mar 29, 2023

I was a Vivaldi user until recently. They had a bug that wiped all my bookmarks so I jumped to Brave. That was fine until this bug in 4.19.0 showed up. And even then it is OK on Linux. You can go to your Extensions page and enable Developer Mode, export your settings from floccus, remove it, download the crx file for the release you want, and drop it on the Developer Mode Extensions page.

But with the Windows version of Brave, it won't let you install a crx extension for any version different than the one currently published on the Chrome Webstore. Here is a thread about that brave/brave-browser#20296.

Last night I tried Midori - didn't like it's lack of features, search engine limitations specifically. Then I tried SRWare Iron, and it allowed me to install the crx file the usual way, but when I did a forced download of my bookmarks they didn't appear on my Bookmarks bar. Perhaps I could have figured out what was happening there but it was late and I'd had enough messing around.

One workaround might be for @marcelklehr to pull the v4.19.0 off the Chrome Store and re-publish v4.18.1 so I could get that version back on my Windows/Brave machines.

@marcelklehr
Copy link
Member

it does work for bookmarks in folders below the Bookmark Bar but not for changes on the bookmark bar.

Which folder do you have selected as your local sync target in this scenario?

@dsiminiuk
Copy link
Author

@marcelklehr Here is a snip...
2023-03-29_10-18

@marcelklehr
Copy link
Member

Thanks!

@baritell
Copy link

For me I have it set to /Bookmarks Toolbar/. Just fyi, in case it matters. Thanks for your help!
image

@marcelklehr
Copy link
Member

@baritell Thanks for confirming, this affects everyone syncing the main / built-in folders (but not the absolute untitled root folder).

@dsiminiuk
Copy link
Author

@baritell The name of it is browser dependent.

@marcelklehr
Copy link
Member

It seems I'm unable to publish a new release without having to push out a patch a few days later ... 🙈 Preparing a release with the fix as we speak

@marcelklehr
Copy link
Member

Should be fixed with v4.19.1 -- coming to a machine near you soon-ish.

@dsiminiuk
Copy link
Author

@marcelklehr Now that v4.19.1 is available on the Chrome Webstore I was able to install it on the WIndows/Brave PCs and all is good. I did remove the 4.19.0 and add back 4.19.1 importing a previously exported .json file and then did a one time pull initially, now everything syncs perfectly.

Thank you for your quick action. This extension (and Bitwarden for passwords) keep me sane. Another contribution is on the way.

@marcelklehr
Copy link
Member

Thank you for your quick action. This extension (and Bitwarden for passwords) keep me sane. Another contribution is on the way.

thank you 💙 I'm glad you like it!

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2024
@marcelklehr marcelklehr moved this to Done in Floccus May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

6 participants