Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with pongo2/v4 #8

Closed
kataras opened this issue Sep 16, 2020 · 0 comments · Fixed by kataras/iris#1636
Closed

Compatible with pongo2/v4 #8

kataras opened this issue Sep 16, 2020 · 0 comments · Fixed by kataras/iris#1636

Comments

@kataras
Copy link
Contributor

kataras commented Sep 16, 2020

Hello @flosch, three days ago you published the pongo2 v4 however, this pongo2-addons are incompatible with that version. I've made the necessary changes in my pongo2-addons fork's branch v4.0.0. But, I cant publish to master because it will break the compatibility for the old users, that's why I am recommending you to create a new branch: v4 or v4.0.0, so I can push my PR here, and then you can just push a release of v4.0.0, the new import path will be:

github.com/flosch/pongo2-addons/v4 

will work for pongo2/v4

And the existing github.com/flosch/pongo2-addons will still working with pre-v4 users of pongo2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant