react-apollo causes flow-typed install to error

[jackmellis]

When I run flow-typed install it fails because the react-apollo definition contains a CONTRIBUTING.md file:

https://github.com/flowtype/flow-typed/blob/master/definitions/npm/react-apollo_v2.x.x/CONTRIBUTING.md

This is a pretty big blocker for me 😞

[eryon]

@gantoine @TLadd @budde377
👍 as of #2172

Stack trace:

UNCAUGHT ERROR: Error: react-apollo_v2.x.x/CONTRIBUTING.md: Unexpected file name. This directory can only contain test files or a libdef file named `react-navigation_v2.x.x.js`.
    at validationError (/<project>/node_modules/flow-typed/dist/lib/validationErrors.js:14:11)
    at /<project>/node_modules/flow-typed/dist/lib/npm/npmLibDefs.js:113:53

[eryon]

This is an issue with react-navigation_v1.x.x and react-navigation_v2.x.x as well (#1925 and #2210)

@jackmellis there is a work-around to just remove the offending CONTRIBUTING.md files from your local clone of the repository. Check ~/.flow-typed/repo/definitions/npm/<libdef>.

[TLadd]

Are y'all on the latest version of flow-typed? It appears some work was put in to allow this:
#1926
#1962

[eryon]

@TLadd correct, thanks. I was on flow-typed@^2.3.0 and updating the dependency has resolved the issue.

[gantoine]

Thanks for taking this one @TLadd ! I'll be deprecating lower versions on npm once we're done breaking stuff.

[jackmellis]

I use flow-typed via npx i.e. npx flow-typed install which is still throwing even after clearing my npm cache. Any ideas?

^ my bad, I had an old global install that npx was picking up instead of the latest version!

[AndrewSouthpaw]

I think our tally of issues regarding this is in the double digits now. 😆