Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Make topology hop with non-FFI snippet [fixes LNG-125] #764

Merged
merged 11 commits into from
Jul 6, 2023

Conversation

InversionSpaces
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jun 19, 2023

LNG-125 Replace `Op.noop` with a non-FFI snippet

Currently, topology hops are done using Op.noop function call that exits AquaVM, does nothing, and than returns into AquaVM to figure out what's next.

This could be replaced with smth like:

(new $op
  (new #noop
    (canon peer_id $op #noop)
  )
)

It does the same (moves execution to peer_id, leaves this move in the execution trace), but with no FFI calls, so should be twice as efficient.

@InversionSpaces InversionSpaces force-pushed the feature/no-ffi branch 2 times, most recently from 5a16ed3 to 0a39ad5 Compare June 19, 2023 15:14
@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Jun 19, 2023
@InversionSpaces InversionSpaces force-pushed the feature/no-ffi branch 3 times, most recently from 8a37c99 to 54c4829 Compare June 20, 2023 10:05
@@ -46,8 +46,6 @@ object DataView {

case class Variable(name: String) extends DataView

case class Stream(name: String) extends DataView
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this bc did not see how it is useful

@InversionSpaces InversionSpaces force-pushed the feature/no-ffi branch 2 times, most recently from f3aafa7 to 3625e87 Compare July 5, 2023 15:22
@InversionSpaces InversionSpaces merged commit c1fe24b into main Jul 6, 2023
@InversionSpaces InversionSpaces deleted the feature/no-ffi branch July 6, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants