Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AquaVM panic handler #143

Closed
mikevoronov opened this issue Sep 28, 2021 · 1 comment · Fixed by #144
Closed

AquaVM panic handler #143

mikevoronov opened this issue Sep 28, 2021 · 1 comment · Fixed by #144
Assignees

Comments

@mikevoronov
Copy link
Member

At the moment AquaVM uses the abort panic handler, that doesn't provide any unwind actions in case of panic. Among other things it leads to persist already loaded data into the interpreter, since desctructors wouldn't be called. In a situation when memory growing failed since docker limits with panic, it leads interpreter to be out of serivce and unability to handle other incoming requests.

This one is on of issues of #141.

Using unwind panic hadlers will require more computation effort, but in future we could overcome it by run interpreter with a fresh memory every time, since it's stateless. But this change would require a lot of work on the Marine side.

@mikevoronov mikevoronov self-assigned this Sep 28, 2021
@mikevoronov
Copy link
Member Author

I think that we should enable debug info (https://github.com/fluencelabs/aquavm/blob/master/Cargo.toml#L22) in the interpreter at least for a while, because now it's in the actively development stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant