Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-distributor): core-manager refactoring [fixes NET-820] #2265

Merged
merged 30 commits into from
Jun 4, 2024
Merged

feat(core-distributor): core-manager refactoring [fixes NET-820] #2265

merged 30 commits into from
Jun 4, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented May 27, 2024 •
edited
Loading

Description

Refactoring core-distributor (ex. core-manager)

Motivation

It isn't easy to test everything with the previous version of the core manager. It introduced a few abstractions that allow for simplified testing.

Related Issue(s)

NET-820

Proposed Changes

  • Added abstraction for the pinning
  • Added abstraction for fetching topology

Additional Notes

  • core-manager renamed to the core-distributor
  • added support of the automock macros under the specific feature

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented May 27, 2024

NET-820 Core manager refactoring

@gurinderu gurinderu changed the title Feature/net 820 feat(core-distributor): core-manager refactoring May 27, 2024
@gurinderu gurinderu added the e2e Run e2e workflow label May 27, 2024
@gurinderu gurinderu changed the title feat(core-distributor): core-manager refactoring feat(core-distributor): core-manager refactoring [fixes NET-820] May 28, 2024
@gurinderu gurinderu marked this pull request as ready for review May 28, 2024 13:15
mikevoronov
mikevoronov reviewed Jun 4, 2024
View reviewed changes
crates/core-distributor/src/distributor.rs Show resolved Hide resolved
crates/core-distributor/src/distributor.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/distributor.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/distributor.rs Show resolved Hide resolved
crates/core-distributor/src/distributor.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/distributor.rs Show resolved Hide resolved
crates/core-distributor/src/distributor.rs Show resolved Hide resolved
crates/core-distributor/src/persistence.rs Show resolved Hide resolved
crates/core-distributor/src/persistence.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/strategy.rs Outdated Show resolved Hide resolved
mikevoronov
mikevoronov reviewed Jun 4, 2024
View reviewed changes
crates/core-distributor/src/persistence.rs Outdated Show resolved Hide resolved
nox/tests/http_test_config.toml Outdated Show resolved Hide resolved
nox/tests/http_expected_config.toml Outdated Show resolved Hide resolved
nox/Cargo.toml Outdated Show resolved Hide resolved
default.nix Outdated Show resolved Hide resolved
crates/core-distributor/src/types.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/strategy.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/strategy.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/strategy.rs Outdated Show resolved Hide resolved
crates/core-distributor/src/strategy.rs Outdated Show resolved Hide resolved
mikevoronov
mikevoronov approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gurinderu gurinderu enabled auto-merge (squash) June 4, 2024 14:09
@gurinderu gurinderu merged commit 58ea53d into master Jun 4, 2024
14 checks passed
@gurinderu gurinderu deleted the feature/net-820 branch June 4, 2024 15:23
@fluencebot fluencebot mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mikevoronov mikevoronov mikevoronov approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurinderu @mikevoronov