Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): extend peer.identify with vm connection info #2364

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Sep 12, 2024

Description

Provide a way for users to know where to connect to.

Proposed Changes

Extend Peer.identify() with new field vm_info:

{
    "node_version": "0.27.1",
    "spell_version": "0.7.5",
    "air_version": "0.63.0",
    "vm_info": {
      "default_ssh_port": 922,
      "forwarded_ports": [
        "1000-65535"
      ],
      "ip": "1.1.1.1"
    },
    "external_addresses": [],
    "allowed_binaries": [
      "/bin/curl"
    ]
  }

@kmd-fl kmd-fl requested a review from mikevoronov September 12, 2024 13:41
@kmd-fl kmd-fl added the e2e Run e2e workflow label Sep 12, 2024
@kmd-fl kmd-fl enabled auto-merge (squash) September 13, 2024 09:21
@kmd-fl kmd-fl merged commit e29fca5 into master Sep 13, 2024
14 checks passed
@kmd-fl kmd-fl deleted the provide-public-ip branch September 13, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants