Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config,cpu,proofs): change cpu and batching defaults #2377

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

justprosh
Copy link
Member

Description

default_min_batch_count=5
default_max_batch_count=30
default_max_proof_batch_size=128

default_system_cpu_count=1
default_cpus_range=1-total # we always leave 1 core to OS

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

default_min_batch_count=5
default_max_batch_count=30
default_max_proof_batch_size=128

default_system_cpu_count=1
default_cpus_range=1-total # we always leave 1 core to OS
@justprosh justprosh requested a review from folex September 17, 2024 12:32
@justprosh justprosh added the e2e Run e2e workflow label Sep 17, 2024
Comment on lines 276 to 286
pub fn default_min_batch_count() -> usize {
1
5
}

pub fn default_max_batch_count() -> usize {
4
30
}

pub fn default_max_proof_batch_size() -> usize {
2
128
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write some motivation for these numbers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous numbers had no motivation, these one are set by @mikevoronov request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do better this time :)

Co-authored-by: folex <0xdxdy@gmail.com>
Co-authored-by: folex <0xdxdy@gmail.com>
@folex folex changed the title feat(defaults): change cpu and batching defaults feat(config,cpu,proofs): change cpu and batching defaults Sep 17, 2024
@folex folex merged commit da7f90e into master Sep 17, 2024
4 of 12 checks passed
@folex folex deleted the change-default branch September 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants