-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config,cpu,proofs): change cpu and batching defaults #2377
Conversation
default_min_batch_count=5 default_max_batch_count=30 default_max_proof_batch_size=128 default_system_cpu_count=1 default_cpus_range=1-total # we always leave 1 core to OS
crates/server-config/src/defaults.rs
Outdated
pub fn default_min_batch_count() -> usize { | ||
1 | ||
5 | ||
} | ||
|
||
pub fn default_max_batch_count() -> usize { | ||
4 | ||
30 | ||
} | ||
|
||
pub fn default_max_proof_batch_size() -> usize { | ||
2 | ||
128 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write some motivation for these numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous numbers had no motivation, these one are set by @mikevoronov request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do better this time :)
Co-authored-by: folex <0xdxdy@gmail.com>
Co-authored-by: folex <0xdxdy@gmail.com>
Description
default_min_batch_count=5
default_max_batch_count=30
default_max_proof_batch_size=128
default_system_cpu_count=1
default_cpus_range=1-total # we always leave 1 core to OS
Checklist
Reviewer Checklist