Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lint JavaScript in Markdown #17

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

greatislander
Copy link
Contributor

No description provided.

@greatislander greatislander self-assigned this Aug 15, 2023
@greatislander greatislander added the enhancement New feature or request label Aug 15, 2023
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for trivet-monolingual ready!

Name Link
🔨 Latest commit ea038ed
🔍 Latest deploy log https://app.netlify.com/sites/trivet-monolingual/deploys/64dbb14c3030ee000969d80b
😎 Deploy Preview https://deploy-preview-17--trivet-monolingual.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jobara
Copy link
Member

jobara commented Aug 15, 2023

@greatislander I tried adding a code block to the README but the linting always passed.

let test = 'test'

let function (a) {return b;}

plain text

let obj = {
  a: "a",
}

@greatislander
Copy link
Contributor Author

greatislander commented Aug 15, 2023

@jobara did you label it as a JavaScript block, e.g.:

```js
// code
```

@jobara
Copy link
Member

jobara commented Aug 15, 2023

@jobara did you label it as a JavaScript block, e.g.:

// code

I had labelled it JavaScript. It does lint when labelled js.

@greatislander greatislander merged commit efac02a into fluid-project:main Aug 15, 2023
6 checks passed
@greatislander greatislander deleted the feat/lint-js-in-md branch August 15, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants