feat: updated tool extrusion settings to respect printer config #1038
Conversation
| const safeAmount = Math.min(amount, this.maxExtrudeLength) | ||
| const safeRate = Math.min(rate, this.maxExtrudeSpeed) |
There was a problem hiding this comment.
This logic isn't strictly necessary as this.valid does a pretty good job of ensuring correctness before issuing an extrude/retract command. However, I so like this as a guardrail since it allows us to be confident that an extruder command won't exceed machine limits even if there was a logic bug in this form.
Now that I'm typing it out, I'm wondering if Klipper would even respect a command that would exceed its specified limits. I should test that.
At any rate, if Klipper handles this or if it's generally unwanted, I'll remove this portion. Just let me know!
There was a problem hiding this comment.
I can confirm that Klipper will indeed complain if the value is above the max_extrude_only_distance (for both extrusion and retraction)
There was a problem hiding this comment.
That should not be necessary (to be honest, even the valid check is probably overkill here), so I've gone ahead and reverted that small bit before doing the actual merge
|
I didn't know whether to title this as a feature or a bug fix or something else, so I defaulted to |
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
changed the title
Fixes #1032
Updates the
ToolheadSettingscomponent to respect an extruder'smax_extrude_only_velocityandmax_extrude_only_distancewhen trying to update the default extrusion distance/speed values. Also adds a last-resort speed/distance check on extrusion/retraction commandsSigned-off-by: Kieran Eglin kieran.eglin@gmail.com