feat: allow ordering of gcode macros #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
commented
Feb 16, 2023
| @@ -40,37 +40,31 @@ export const getters: GetterTree<MacrosState, RootState> = { | |||
|
|
|||
| return macro | |||
| }) | |||
| .sort((a, b) => a.name.localeCompare(b.name)) | |||
|
|
|||
| return macros | |||
| }, | |||
|
|
|||
| // Gets visible macros, transformed. Should include the macro's config. | |||
| // Is only used on the dashboard. Grouped by category. | |||
| getVisibleMacros: (state, getters) => { | |||
There was a problem hiding this comment.
This needed to be updated to utilize getMacrosByCategory so that macros would be sorted per-category, rather than being sorted overall then split into categories which lead to unexpected behaviour. Since I needed to update it anyway, I thought I'd refactor it to DRY things up somewhat
There was a problem hiding this comment.
Good point, this was actually rather stupid considering we will then do other operations on this!
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
approved these changes
Feb 18, 2023
matmen
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1027
Signed-off-by: Kieran Eglin kieran.eglin@gmail.com
Screen.Recording.2023-02-16.at.2.19.50.PM.mov