fix: allow applying z-offset to endstop or probe #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrolamas
force-pushed
the
pedrolamas/fix-1084
branch
from
b23c6ca
to
4ad1059
Compare
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
force-pushed
the
pedrolamas/fix-1084
branch
from
4ad1059
to
536ebb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking for type of probe/endstop, we will now check for the existence of
Z_OFFSET_APPLY_ENDSTOPandZ_OFFSET_APPLY_PROBEIf only one of these exists, then we save directly via that command; if both exist, we will show a menu and allow the user to pick which to use.
We are also NOT forcing the restart, and instead letting the user decide if/when to do it via the "Save Config & Restart" button on top of Fluidd.
Single case
Multiple case
Fixes #1084