Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects original source attributions #1276

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

vajonam
Copy link
Contributor

@vajonam vajonam commented Dec 14, 2023

fix: add attribution and inspiration for the source circle control was adapted from. This was already in the original PR, making it more obvious by moving out the top.

Signed-off-by: vajonam 152501+vajonam@users.noreply.github.com

Signed-off-by: vajonam <152501+vajonam@users.noreply.github.com>
Signed-off-by: vajonam <152501+vajonam@users.noreply.github.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@meteyou
Copy link

meteyou commented Dec 15, 2023

Many thanks for adding the links to Mainsail. I personally think the "heavily adapted" sounds "bad". I would consider "adapted for fluidd" to be "correct" in this case.

just my 2 cents...

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added this to the 1.27.1 milestone Dec 15, 2023
@pedrolamas pedrolamas changed the title fix: add attribution to orginal source and inspriration fix: corrects original source attributions Dec 15, 2023
@pedrolamas pedrolamas merged commit 8ee1312 into fluidd-core:develop Dec 15, 2023
5 checks passed
@vajonam vajonam deleted the fix/add_atrribution_for_svg branch December 15, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants