fix: don't assume user is trusted when force_logins is turned off #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Mensing <github@matmen.dev>
I think I just didn't think of the scenario we are talking here (unauthorized client) and thus assumed I've tested this PR and seems to work fine, so I think we are good to merge in. |
pedrolamas
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1317.
I've tested theme loading and couldn't reproduce the issue described in #1065, so I don't think there's any side effects. Not sure why the
!forceLoginscheck was required in the first place in e5d177c, @pedrolamas any chance you remember?edit: Looks like it was there to prevent unnecessary oneshot token requests, but I think the
_TRUSTED_USER_check should handle all of that