Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow percentage-based inputs in color picker #1374

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

matmen
Copy link
Member

@matmen matmen commented Feb 25, 2024

Closes #1368

image image

@matmen matmen added the FR - Enhancement New feature or request label Feb 25, 2024
Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen force-pushed the feat/colorpicker-percentage-input branch from ab5ea60 to 0c8bfe1 Compare February 28, 2024 21:15
@matmen matmen marked this pull request as ready for review February 28, 2024 21:22
@matmen matmen added this to the 1.28.2 milestone Feb 28, 2024
@matmen
Copy link
Member Author

matmen commented Feb 28, 2024

Also, I'm not sure if there should be a setting (either server-wide or saved in the browser) to set a default value range. @thijstriemstra Would you mainly be using the 0..1 range and would remembering the last selection be useful in your case?

@thijstriemstra
Copy link
Contributor

thijstriemstra commented Feb 29, 2024

Would you mainly be using the 0..1 range and would remembering the last selection be useful in your case?

Not sure what you mean..

I would refer to the klipper docs on [neopixel](and [led]): https://www.klipper3d.org/Config_Reference.html#neopixel

#initial_RED: 0.0
#initial_GREEN: 0.0
#initial_BLUE: 0.0
#initial_WHITE: 0.0
#   Sets the initial LED color. Each value should be between 0.0 and
#   1.0. The default for each color is 0.

As well as: https://www.klipper3d.org/G-Codes.html#led

Each color <value> must be between 0.0 and 1.0. The WHITE option is only valid on RGBW LEDs. 

@matmen
Copy link
Member Author

matmen commented Feb 29, 2024

@thijstriemstra I'm just asking if you want an option to remember the last choice (either 0..255 or 0..1) so you don't have to switch to 0..1 every time you open the color picker (if you primarily use the 0..1 option) :D

@thijstriemstra
Copy link
Contributor

thijstriemstra commented Feb 29, 2024

you don't have to switch to 0..1 every time

oh, yes, good idea. Just wanted to point out some people need 4 input fields (RGBW leds).

matmen and others added 3 commits February 29, 2024 20:24
Signed-off-by: Mathis Mensing <github@matmen.dev>
Signed-off-by: Mathis Mensing <github@matmen.dev>
pedrolamas
pedrolamas previously approved these changes Feb 29, 2024
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen merged commit 3aa7269 into fluidd-core:develop Feb 29, 2024
4 checks passed
@matmen matmen deleted the feat/colorpicker-percentage-input branch February 29, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGB 0-1 colorpicker support
3 participants