Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Klipper can_extrude by default #1397

Merged

Conversation

CromFr
Copy link
Contributor

@CromFr CromFr commented Mar 20, 2024

Current conditions disabled extrusion controls on Fluidd if the klipper min_extrude_temp protection is set to a sub-zero temp.

For some context, I'm working on a ceramic printer, that does not have any heater nor thermistor on the hotend. The quick and easy way to disable any temp-related security on klipper is to set min_extrude_temp to -273.15, so that any temp detected by a connected (or in my case disconnected) thermistor won't prevent the extrusion.

While this works as expected with klipper (sending G1 E10 does extrude), the extrusion controls on fluidd are disabled with this cheeky message:
image

Note: I haven't looked at how min_extrude_temp is fetched by fluidd, maybe a value of 0 has a special meaning (i.e. a default value when undefined / could not be fetched?)

@CromFr CromFr force-pushed the allow-extrusion-with-negative-temps branch from 3e739d9 to 2f7d599 Compare March 20, 2024 13:44
Signed-off-by: Thibaut CHARLES <CromFr@gmail.com>
@CromFr CromFr force-pushed the allow-extrusion-with-negative-temps branch from 2f7d599 to 579fbbc Compare March 20, 2024 13:45
Klipper added `can_extrude` at least 2 years ago, so we should use this property if available and fallback to current behavior otherwise.
@pedrolamas pedrolamas changed the title Allow extrusion if min_extrude_temp is below zero fix: use Klipper can_extrude by default Mar 20, 2024
@pedrolamas pedrolamas added the GH - Bug Something isn't working label Mar 20, 2024
@pedrolamas pedrolamas added this to the 1.29.1 milestone Mar 20, 2024
@pedrolamas pedrolamas requested a review from matmen March 20, 2024 16:51
@pedrolamas
Copy link
Member

Hi @CromFr, thank you for opening this Pull Request.

I've made a few changes as to use the can_extrude property that is already provided by Klipper as the defualt "source of truth" so that it will match whatever Klipper says, and fallback to current behavior if that property is not available (only for 2+ year old Klipper deployments)

@CromFr
Copy link
Contributor Author

CromFr commented Mar 20, 2024

That's a much better solution indeed !

@matmen matmen merged commit 83f4fb2 into fluidd-core:develop Mar 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants