feat: larger thumbnail preview #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmen
added
FR - Enhancement
Signed-off-by: Mathis Mensing <github@matmen.dev>
Signed-off-by: Mathis Mensing <github@matmen.dev>
matmen
force-pushed
the
feat/thumbnail-preview
branch
from
b6dad66
to
e7394e1
Compare
Signed-off-by: Mathis Mensing <github@matmen.dev>
pedrolamas
approved these changes
Oct 7, 2022
matmen
added a commit
to matmen/fluidd
that referenced
this pull request
Oct 15, 2022
Removes the "View Thumbnail" button from the UI and replaces it with the functionality to simply click the thumbnail in order to open it in the file previewer. Follow-Up for fluidd-core#891 Signed-off-by: Mathis Mensing <mathis@matmen.dev>
matmen
added a commit
that referenced
this pull request
Oct 15, 2022
Removes the "View Thumbnail" button from the UI and replaces it with the functionality to simply click the thumbnail in order to open it in the file previewer. Follow-Up for #891 Signed-off-by: Mathis Mensing <mathis@matmen.dev>
|
SuperSlicer > Printer Settings > Thumbnails > 200x200 for small and 1200x900 for large Works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the practicality on this one, considering the default thumbnail size configured in most slicers is still not very large.
As already explained by @ChaosBlades in #884 this can of course be configured, though.
I think this can still be useful considering opening thumbnails in a new tab just downloads them.
Maybe the styling (especially width) of the preview modal still needs to be adjusted to be able to show huge thumbnails?
Closes #884