feat: supports Klipper output pin toggle in AppBar #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
added
FR - Enhancement
matmen
approved these changes
Dec 7, 2022
koriwi
pushed a commit
to koriwi/fluidd
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already allowed for a Moonraker Power Device toggle on the top AppBar, this adds the possibility of using a Klipper OutputPin instead!
Only visible difference is on the "Power toggle in top navigation" dropdown setting:
Everything else remains unchanged, although for Klipper output pin toggle it will show the
SET_PINcommands on the console.This will deprecate #864
Signed-off-by: Pedro Lamas pedrolamas@gmail.com