Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A value greater than 0 is required for a Thermal Preset device even if it is not selected #993

Closed
ChaosBlades opened this issue Dec 25, 2022 · 0 comments · Fixed by #995
Closed

A value greater than 0 is required for a Thermal Preset device even if it is not selected #993

ChaosBlades opened this issue Dec 25, 2022 · 0 comments · Fixed by #995
Assignees
@pedrolamas
Labels
GH - Bug Something isn't working
Milestone
1.23

Comments

@ChaosBlades
Copy link

Fluidd Version

v1.22.2-ca7234d

Browser

Other (Please tell us below)

Device

Desktop PC

Operating System

Linux

What happened

Trying to add a Thermal Preset to heat the chamber but I can't without entering a value for unselected devices. Add button does nothing unless I enter a value of 1 or greater. Once I enter a value I can then Add the preset even though the unselected device is not used.

What did you expect to happen

The value requirement should be removed when a device is not selected.

How to reproduce

Screenshot from 2022-12-24 19-35-06
Screenshot from 2022-12-24 19-35-31

Additional information

No response
@ChaosBlades ChaosBlades added GH - Bug Something isn't working GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability labels Dec 25, 2022
@pedrolamas pedrolamas removed the GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability label Dec 26, 2022
@pedrolamas pedrolamas added this to the 1.23 milestone Dec 26, 2022
@pedrolamas pedrolamas self-assigned this Dec 26, 2022
@pedrolamas pedrolamas mentioned this issue Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedrolamas pedrolamas

Labels
GH - Bug Something isn't working
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

fix: only validate enabled fields in PresetDialog pedrolamas/fluidd
2 participants
@pedrolamas @ChaosBlades