Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormBuilderTextField does not respect the constructor parameter "enabled" #76

Closed
Jordan-Nelson opened this issue Jun 9, 2019 · 2 comments

Comments

@Jordan-Nelson
Copy link

Jordan-Nelson commented Jun 9, 2019

FormBuilderTextField has a constructor parameter enabled, but it is not used. readonly is used instead. This can be seen here. This is inconsistent with the Flutter API for TextField.

Solution: Support enabled to be consistent with the Flutter API for TextField. Deprecate readonly but continue to support it for backwards compatibility.

@danvick
Copy link
Collaborator

danvick commented Jun 10, 2019

This is a great idea! It will definitely be considered going forward.

Your positive contribution is greatly appreciated.

@danvick
Copy link
Collaborator

danvick commented Jul 12, 2019

Hi @jrnelson333,
I was working on changing the readonly property to enabled but it seems Flutter have in the latest versions included readOnly property in the API for TextField.

What we may need to do therefore is to change readonly to readOnly.

I'm therefore going ahead to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants