From 69f16f0d6e3958cd476ace616b95e99ddb08c69b Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Fri, 14 Jul 2023 13:46:27 -0400 Subject: [PATCH 1/3] Add infra notation to infra tasks in packages repo --- .ci/targets/analyze.yaml | 1 + .ci/targets/analyze_legacy.yaml | 1 + .ci/targets/android_build_all_packages.yaml | 2 ++ .ci/targets/dart_unit_tests.yaml | 1 + .ci/targets/ios_build_all_packages.yaml | 2 ++ .ci/targets/ios_platform_tests.yaml | 2 ++ .ci/targets/linux_build_all_packages.yaml | 2 ++ .ci/targets/linux_custom_package_tests.yaml | 1 + .ci/targets/macos_build_all_packages.yaml | 2 ++ .ci/targets/macos_check_podspecs.yaml | 1 + .ci/targets/macos_custom_package_tests.yaml | 2 ++ .ci/targets/macos_platform_tests.yaml | 1 + .ci/targets/repo_checks.yaml | 1 + .ci/targets/repo_tools_tests.yaml | 1 + .ci/targets/web_build_all_packages.yaml | 2 ++ .ci/targets/web_dart_unit_tests.yaml | 1 + .ci/targets/web_platform_tests.yaml | 1 + .ci/targets/windows_build_all_packages.yaml | 2 ++ .ci/targets/windows_build_and_platform_tests.yaml | 1 + .ci/targets/windows_custom_package_tests.yaml | 1 + .ci/targets/windows_dart_unit_tests.yaml | 1 + 21 files changed, 29 insertions(+) diff --git a/.ci/targets/analyze.yaml b/.ci/targets/analyze.yaml index 02ae19504c2e..793ac03e2664 100644 --- a/.ci/targets/analyze.yaml +++ b/.ci/targets/analyze.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: analyze repo tools script: .ci/scripts/analyze_repo_tools.sh - name: analyze diff --git a/.ci/targets/analyze_legacy.yaml b/.ci/targets/analyze_legacy.yaml index 3c95e6c0e1ce..0d2d33358462 100644 --- a/.ci/targets/analyze_legacy.yaml +++ b/.ci/targets/analyze_legacy.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. # Does a sanity check that packages at least pass analysis on the N-1 and N-2 # versions of Flutter stable if the package claims to support that version. # This is to minimize accidentally making changes that break old versions diff --git a/.ci/targets/android_build_all_packages.yaml b/.ci/targets/android_build_all_packages.yaml index 6c807e8334d2..5343cfb17961 100644 --- a/.ci/targets/android_build_all_packages.yaml +++ b/.ci/targets/android_build_all_packages.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create all_packages app script: .ci/scripts/create_all_packages_app.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build all_packages for Android debug script: .ci/scripts/build_all_packages_app.sh args: ["apk", "debug"] diff --git a/.ci/targets/dart_unit_tests.yaml b/.ci/targets/dart_unit_tests.yaml index 3d06b600fd55..9d0939d6e28b 100644 --- a/.ci/targets/dart_unit_tests.yaml +++ b/.ci/targets/dart_unit_tests.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: Dart unit tests script: script/tool_runner.sh args: ["dart-test", "--exclude=script/configs/dart_unit_tests_exceptions.yaml", "--platform=vm"] diff --git a/.ci/targets/ios_build_all_packages.yaml b/.ci/targets/ios_build_all_packages.yaml index 3ebef6c7380e..c85ec5c1f7cb 100644 --- a/.ci/targets/ios_build_all_packages.yaml +++ b/.ci/targets/ios_build_all_packages.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create all_packages app script: .ci/scripts/create_all_packages_app.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build all_packages for iOS debug script: .ci/scripts/build_all_packages_app.sh args: ["ios", "debug", "--no-codesign"] diff --git a/.ci/targets/ios_platform_tests.yaml b/.ci/targets/ios_platform_tests.yaml index a89554ee65c1..3b4d22a32010 100644 --- a/.ci/targets/ios_platform_tests.yaml +++ b/.ci/targets/ios_platform_tests.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create simulator script: .ci/scripts/create_simulator.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build examples script: script/tool_runner.sh args: ["build-examples", "--ios"] diff --git a/.ci/targets/linux_build_all_packages.yaml b/.ci/targets/linux_build_all_packages.yaml index b54f7b1e56c2..7d634af090af 100644 --- a/.ci/targets/linux_build_all_packages.yaml +++ b/.ci/targets/linux_build_all_packages.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create all_packages app script: .ci/scripts/create_all_packages_app.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build all_packages for Linux debug script: .ci/scripts/build_all_packages_app.sh args: ["linux", "debug"] diff --git a/.ci/targets/linux_custom_package_tests.yaml b/.ci/targets/linux_custom_package_tests.yaml index 8c691789a814..b64cd96059a9 100644 --- a/.ci/targets/linux_custom_package_tests.yaml +++ b/.ci/targets/linux_custom_package_tests.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: custom tests script: script/tool_runner.sh args: ["custom-test"] diff --git a/.ci/targets/macos_build_all_packages.yaml b/.ci/targets/macos_build_all_packages.yaml index 0810966c084b..6cc476559593 100644 --- a/.ci/targets/macos_build_all_packages.yaml +++ b/.ci/targets/macos_build_all_packages.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create all_packages app script: .ci/scripts/create_all_packages_app.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build all_packages for macOS debug script: .ci/scripts/build_all_packages_app.sh args: ["macos", "debug"] diff --git a/.ci/targets/macos_check_podspecs.yaml b/.ci/targets/macos_check_podspecs.yaml index 0b2217325635..9df7e66afd41 100644 --- a/.ci/targets/macos_check_podspecs.yaml +++ b/.ci/targets/macos_check_podspecs.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: validate iOS and macOS podspecs script: script/tool_runner.sh args: ["podspec-check"] diff --git a/.ci/targets/macos_custom_package_tests.yaml b/.ci/targets/macos_custom_package_tests.yaml index 5e5b2553aea4..e5196cb047dc 100644 --- a/.ci/targets/macos_custom_package_tests.yaml +++ b/.ci/targets/macos_custom_package_tests.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create simulator script: .ci/scripts/create_simulator.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: custom package tests script: .ci/scripts/custom_package_tests.sh - name: remove simulator diff --git a/.ci/targets/macos_platform_tests.yaml b/.ci/targets/macos_platform_tests.yaml index 4b2ee4eac1fe..92b937e94362 100644 --- a/.ci/targets/macos_platform_tests.yaml +++ b/.ci/targets/macos_platform_tests.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build examples script: script/tool_runner.sh args: ["build-examples", "--macos"] diff --git a/.ci/targets/repo_checks.yaml b/.ci/targets/repo_checks.yaml index eccc1431d5ff..f5a5f1d112fe 100644 --- a/.ci/targets/repo_checks.yaml +++ b/.ci/targets/repo_checks.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: format script: script/tool_runner.sh args: ["format", "--fail-on-change"] diff --git a/.ci/targets/repo_tools_tests.yaml b/.ci/targets/repo_tools_tests.yaml index 265e74bdd06b..bd80daeb3fbc 100644 --- a/.ci/targets/repo_tools_tests.yaml +++ b/.ci/targets/repo_tools_tests.yaml @@ -1,5 +1,6 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: tool unit tests script: .ci/scripts/plugin_tools_tests.sh diff --git a/.ci/targets/web_build_all_packages.yaml b/.ci/targets/web_build_all_packages.yaml index d3b7ae010725..1be790f62d5f 100644 --- a/.ci/targets/web_build_all_packages.yaml +++ b/.ci/targets/web_build_all_packages.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create all_packages app script: .ci/scripts/create_all_packages_app.sh + infra_step: true # Note infra steps failing prevents "always" from running. # No debug version, unlike the other platforms, since web does not support # debug builds. - name: build all_packages app for Web release diff --git a/.ci/targets/web_dart_unit_tests.yaml b/.ci/targets/web_dart_unit_tests.yaml index ad56af5144f0..35b8073e241a 100644 --- a/.ci/targets/web_dart_unit_tests.yaml +++ b/.ci/targets/web_dart_unit_tests.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: Dart unit tests - web script: script/tool_runner.sh args: ["dart-test", "--exclude=script/configs/dart_unit_tests_exceptions.yaml", "--platform=chrome"] diff --git a/.ci/targets/web_platform_tests.yaml b/.ci/targets/web_platform_tests.yaml index e2328622bc1f..acfb9cd8a63e 100644 --- a/.ci/targets/web_platform_tests.yaml +++ b/.ci/targets/web_platform_tests.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build examples script: script/tool_runner.sh args: ["build-examples", "--web"] diff --git a/.ci/targets/windows_build_all_packages.yaml b/.ci/targets/windows_build_all_packages.yaml index de30188bf6f6..e7928ac05a85 100644 --- a/.ci/targets/windows_build_all_packages.yaml +++ b/.ci/targets/windows_build_all_packages.yaml @@ -1,8 +1,10 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: create all_packages app script: .ci/scripts/create_all_packages_app.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build all_packages app for Windows debug script: .ci/scripts/build_all_packages_app.sh args: ["windows", "debug"] diff --git a/.ci/targets/windows_build_and_platform_tests.yaml b/.ci/targets/windows_build_and_platform_tests.yaml index cda3e57f75d2..4bd73f913053 100644 --- a/.ci/targets/windows_build_and_platform_tests.yaml +++ b/.ci/targets/windows_build_and_platform_tests.yaml @@ -1,6 +1,7 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: build examples (Win32) script: .ci/scripts/build_examples_win32.sh - name: native unit tests (Win32) diff --git a/.ci/targets/windows_custom_package_tests.yaml b/.ci/targets/windows_custom_package_tests.yaml index 46ea2506d1c4..91df11fca352 100644 --- a/.ci/targets/windows_custom_package_tests.yaml +++ b/.ci/targets/windows_custom_package_tests.yaml @@ -1,5 +1,6 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: custom package tests script: .ci/scripts/custom_package_tests.sh diff --git a/.ci/targets/windows_dart_unit_tests.yaml b/.ci/targets/windows_dart_unit_tests.yaml index 66a99d3e20f8..0dd815de286b 100644 --- a/.ci/targets/windows_dart_unit_tests.yaml +++ b/.ci/targets/windows_dart_unit_tests.yaml @@ -1,5 +1,6 @@ tasks: - name: prepare tool script: .ci/scripts/prepare_tool.sh + infra_step: true # Note infra steps failing prevents "always" from running. - name: dart unit tests script: .ci/scripts/dart_unit_tests_win32.sh From 58d69c2fb9d3083d97a4ab2a48ceb471b007a3b5 Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Mon, 17 Jul 2023 11:18:20 -0400 Subject: [PATCH 2/3] Update ios_platform_tests.yaml to mark simulator removal as infa step --- .ci/targets/ios_platform_tests.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.ci/targets/ios_platform_tests.yaml b/.ci/targets/ios_platform_tests.yaml index 3b4d22a32010..97b92d38309a 100644 --- a/.ci/targets/ios_platform_tests.yaml +++ b/.ci/targets/ios_platform_tests.yaml @@ -27,3 +27,4 @@ tasks: - name: remove simulator script: .ci/scripts/remove_simulator.sh always: true + infra_step: true From a2a11e39e216b86c18f19eba6b0cf3ed45d0e30b Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Mon, 17 Jul 2023 11:19:20 -0400 Subject: [PATCH 3/3] Update macos_custom_package_tests.yaml to mark simulator removal as infra step --- .ci/targets/macos_custom_package_tests.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.ci/targets/macos_custom_package_tests.yaml b/.ci/targets/macos_custom_package_tests.yaml index e5196cb047dc..4b0de789f9ac 100644 --- a/.ci/targets/macos_custom_package_tests.yaml +++ b/.ci/targets/macos_custom_package_tests.yaml @@ -10,3 +10,4 @@ tasks: - name: remove simulator script: .ci/scripts/remove_simulator.sh always: true + infra_step: true