Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Automated updates to a branch #1362

Closed
squaremo opened this issue Sep 14, 2018 · 1 comment
Closed

Automated updates to a branch #1362

squaremo opened this issue Sep 14, 2018 · 1 comment
Labels
blocked-design enhancement flux2 Resolution suggested - already fixed in Flux v2

Comments

@squaremo
Copy link
Member

squaremo commented Sep 14, 2018

Similarly to #1361 (and yet not, read on ..), push commits from automation to a branch.

There is a big difference that makes this more complicated: automation happens unattended, and its updates are based on the current state. It's not enough to just change the branch that it pushes commits to, or to push each to a fresh branch -- if the branch hasn't been merged in the meantime, each subsequent automation run will end up pushing a commit including the same changes as the last.

So this needs to be thought through. A couple of alternative sketches:

  • Wait until the last branch is merged before running automation again

    • this could easily end up over-constraining the system, since in general updates can be done concurrently without waiting for the last
    • what if the branch is deleted? (would have to watch for that too)
  • Annotate resources as having an automated update outstanding, and don't include those in the automation run

    • could work neatly, but no doubt has corner cases (e.g., what if you lose state -- either the running resource or branch is deleted)
@kingdonb kingdonb added the flux2 Resolution suggested - already fixed in Flux v2 label Apr 7, 2021
@kingdonb
Copy link
Member

kingdonb commented Apr 7, 2021

Same disposition as #1361, this is handled in Flux v2 now:

https://toolkit.fluxcd.io/guides/image-update/#push-updates-to-a-different-branch

fluxcd/image-automation-controller#121 made this feature possible in the latest Flux v2 releases.

🌮

@kingdonb kingdonb closed this as completed Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked-design enhancement flux2 Resolution suggested - already fixed in Flux v2
Projects
None yet
Development

No branches or pull requests

2 participants