Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

only push tag if changes #1604

Closed
davidkarlsen opened this issue Dec 15, 2018 · 2 comments
Closed

only push tag if changes #1604

davidkarlsen opened this issue Dec 15, 2018 · 2 comments

Comments

@davidkarlsen
Copy link
Contributor

We send events to slack on changes in our repos - and flux causes an event on every loop run every 5mins - either there are changes or not.

See slack thread: https://weave-community.slack.com/archives/C4U5ATZ9S/p1544906747429300
where I talked to @justinbarrick which found https://github.com/weaveworks/flux/blob/5cdd31490cffd16fd065dee671f2be83c10b4089/git/operations.go#L226 where it seems a push is done either there was a change or not.

Could this be altered to only push if there are in fact changes?

It also causes this problem:

git fetch --tags
remote: Counting objects: 1, done.
remote: Total 1 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (1/1), done.
From ssh://fsstash.evry.com:7999/tac_jfr/flux
 ! [rejected]        flux-sync  -> flux-sync  (would clobber existing tag)
@hiddeco
Copy link
Member

hiddeco commented Dec 17, 2018

I think this is a possible duplicate of #1533.

@squaremo
Copy link
Member

Closing as duplicate, and also because #1605.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants