Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

helm-op: repositories.yaml is sensitive to (missing) trailing slash #1732

Closed
squaremo opened this issue Feb 13, 2019 · 0 comments
Closed

helm-op: repositories.yaml is sensitive to (missing) trailing slash #1732

squaremo opened this issue Feb 13, 2019 · 0 comments

Comments

@squaremo
Copy link
Member

In #1726, a large part of the problem was that missing the trailing slash from the repository URL in the HelmRelease causes a couple of problems:

  1. It can mean helm-op doesn't find authentication details in credentials.yaml, if they happen to have the trailing slash
  2. When downloading a chart tarball, the constructed URL will be missing a path element if there's no trailing slash (e.g., https://myrepo/helm/charts + mychart-1.0.1.tar = https://myrepo/helm/mychart-1.0.1.tar).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant