Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misleading messaging when using -A flag #3531

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

makkes
Copy link
Member

@makkes makkes commented Jan 30, 2023

Before:

$ flux get source git -A
✗ no GitRepository objects found in flux-system namespace

After:

$ flux get source git -A
✗ no GitRepository objects found in any namespace

closes #3530

@makkes makkes force-pushed the fix-misleading-messaging branch from 5573f8b to d124003 Compare January 30, 2023 15:21
@makkes makkes requested review from somtochiama and souleb January 30, 2023 15:21
@makkes makkes self-assigned this Jan 30, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes 🏅

Before:

```
$ flux get source git -A
✗ no GitRepository objects found in flux-system namespace
```

After:

```
$ flux get source git -A
✗ no GitRepository objects found in any namespace
```

Signed-off-by: Max Jonas Werner <max@e13.dev>
@makkes makkes force-pushed the fix-misleading-messaging branch from d124003 to 0648f56 Compare January 30, 2023 15:54
@makkes makkes merged commit 9fb5fe3 into main Jan 30, 2023
@makkes makkes deleted the fix-misleading-messaging branch January 30, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error message when using -A flag to get command
2 participants