Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote bucket commands to GA #5008

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Promote bucket commands to GA #5008

merged 1 commit into from
Sep 27, 2024

Conversation

stefanprodan
Copy link
Member

Update Bucket API to v1 and mark all commands as GA.

Part of: #4947

@stefanprodan stefanprodan added the area/bucket Bucket related issues and pull requests label Sep 27, 2024
cmd/flux/events.go Outdated Show resolved Hide resolved
cmd/flux/source.go Outdated Show resolved Hide resolved
@darkowlzz
Copy link
Contributor

The Bucket provider constants in

sourcev1.GenericBucketProvider,
sourcev1.AmazonBucketProvider,
sourcev1.AzureBucketProvider,
sourcev1.GoogleBucketProvider,
need to be updated to the new constants.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkowlzz
Copy link
Contributor

darkowlzz commented Sep 27, 2024

I think we can ignore the GCP integration failure. I believe changes here are not related to what we test on GCP. GCP failures are known to occur frequently. Some related to their terraform provider and others their service not responding well at first try.

@stefanprodan stefanprodan merged commit 2c7d781 into main Sep 27, 2024
9 of 10 checks passed
@stefanprodan stefanprodan deleted the bucket-ga branch September 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants