Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Clarify meaning of metrics on monitoring.md #381

Closed
cep21 opened this issue Apr 19, 2020 · 1 comment · Fixed by #384
Closed

Clarify meaning of metrics on monitoring.md #381

cep21 opened this issue Apr 19, 2020 · 1 comment · Fixed by #384
Labels
docs Issue or PR related to documentation help wanted Anyone looking to contribute can pick this up

Comments

@cep21
Copy link

cep21 commented Apr 19, 2020

Hi,

I'm reading https://github.com/fluxcd/helm-operator/blob/master/docs/references/monitoring.md and the difference between release_phase_duration_seconds and release_duration_seconds isn't very clear to me. The only difference seems to be "Release" and "Release Phase", which I'm not sure where they are defined. Is it possible to add some clarification comments around how the two metrics are different?

Thanks!

@cep21 cep21 added blocked needs validation In need of validation before further action enhancement New feature or request labels Apr 19, 2020
@hiddeco
Copy link
Member

hiddeco commented Apr 20, 2020

A release consists of one or multiple phases.

The *_release is the total duration of the whole releases process, this includes all preparations and the one or many phases it goes through.

The _*release_phase is the duration of a single phase of type x for that release.

@hiddeco hiddeco added docs Issue or PR related to documentation documentation help wanted Anyone looking to contribute can pick this up and removed blocked needs validation In need of validation before further action enhancement New feature or request labels Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR related to documentation help wanted Anyone looking to contribute can pick this up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants