From 243e8ce5dfcef8a2a03903fcb55eea0addca653f Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Wed, 15 Apr 2020 11:08:54 +0200 Subject: [PATCH] release: do not swallow dependency update errors --- pkg/release/release.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/release/release.go b/pkg/release/release.go index ed65a91d4..f36219659 100644 --- a/pkg/release/release.go +++ b/pkg/release/release.go @@ -146,7 +146,9 @@ func (r *Release) prepareChart(client helm.Client, hr *v1.HelmRelease) (chart, f return 0 < len(i) }() if r.config.UpdateDeps && !hr.Spec.GitChartSource.SkipDepUpdate { - client.DependencyUpdate(chartPath) + if err := client.DependencyUpdate(chartPath); err != nil { + return chart{}, nil, err + } } return chart{chartPath, revision, changed}, export.Clean, nil case hr.Spec.RepoChartSource != nil && hr.Spec.RepoURL != "" && hr.Spec.Name != "" && hr.Spec.Version != "":