Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SOPS to v3.7.0 #302

Closed
hiddeco opened this issue Mar 24, 2021 · 0 comments · Fixed by #304
Closed

Update SOPS to v3.7.0 #302

hiddeco opened this issue Mar 24, 2021 · 0 comments · Fixed by #304
Labels
area/ci CI related issues and pull requests

Comments

@hiddeco
Copy link
Member

hiddeco commented Mar 24, 2021

SOPS v3.7.0 was released about an hour ago, and includes the support for the age encryption format: https://github.com/mozilla/sops/releases/tag/v3.7.0

I tried to do a upgrade using a simple "bump", but due to the modified keyservice package we make use of to be able to decrypt in a contained environment, this does not work without making some modifications to the package first:

internal/sops/keyservice/server.go:68:9: assignment copies lock value to key: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
internal/sops/keyservice/server.go:83:20: call of ks.prompt copies lock value: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
internal/sops/keyservice/server.go:91:22: keyToString passes lock by value: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
internal/sops/keyservice/server.go:100:29: prompt passes lock by value: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
internal/sops/keyservice/server.go:101:27: call of keyToString copies lock value: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
internal/sops/keyservice/server.go:120:9: assignment copies lock value to key: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex
internal/sops/keyservice/server.go:135:20: call of ks.prompt copies lock value: go.mozilla.org/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex

While determining what must be changed, we should probably also look into if and/or what is required to support the age format as well, assuming that the "missing" items in getsops/sops#688 are not blocking.

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Mar 24, 2021
@hiddeco hiddeco changed the title Upgrade to SOPS v3.7.0 Update SOPS to v3.7.0 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant