From 3cc2f27c3cf84e589559c6076af3a164788dc9f5 Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Fri, 23 Jun 2023 16:51:37 +0200 Subject: [PATCH] Disable "empty repository" Git test This is required because the test fails with Git >v2.41.0 due to changes to commands used by the Git test server. Causing the server to return an error when cloning an empty repository, instead of yielding an empty object. Signed-off-by: Hidde Beydals --- internal/controller/gitrepository_controller_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/internal/controller/gitrepository_controller_test.go b/internal/controller/gitrepository_controller_test.go index 22f9070a3..717527371 100644 --- a/internal/controller/gitrepository_controller_test.go +++ b/internal/controller/gitrepository_controller_test.go @@ -219,6 +219,11 @@ func TestGitRepositoryReconciler_Reconcile(t *testing.T) { testSuspendedObjectDeleteWithArtifact(ctx, g, obj) } +// TODO(hidde): Re-enable this test. +// It is currently disabled because it fails on machines with Git version +// >=v2.41.0 due to changes to commands used by the test server. Causing +// the test server to return an error when cloning an empty repository, +// instead of yielding an empty object. //func TestGitRepositoryReconciler_reconcileSource_emptyRepository(t *testing.T) { // g := NewWithT(t) //