Source filesystem execute permission is being overwritten in the artifact archive

[rashedkvm]

Hi guys, I am encountering an issue with Flux Source Controller v0.36.1 with filesystem execute permission being overwritten and set to a default permission 0o644 for files in the artifact archive. This change was introduced in #1020. For instance, we have a Java project with a script running a few mvn commands. After pulling the source, the ./mvnw script is missing the execute permission -rw-r--r-- 1 root root 10284 Jan 1 1970 mvnw.

Details from the extracted source .status.artifact.url

ls -al /tmp/source
total 124
drwxr-xr-x 7 root root  4096 Jan  1  1970 .
drwxr-xr-x 3 root root  4096 May 10 13:14 ..
drwxr-xr-x 4 root root  4096 Jan  1  1970 .git
drwxr-xr-x 3 root root  4096 Jan  1  1970 .mvn
-rw-r--r-- 1 root root   678 Jan  1  1970 .tanzuignore
-rw-r--r-- 1 root root   907 Jan  1  1970 LICENSE
-rw-r--r-- 1 root root  1565 Jan  1  1970 README.md
-rw-r--r-- 1 root root   994 Jan  1  1970 Tiltfile
-rw-r--r-- 1 root root  1400 Jan  1  1970 accelerator-info.yaml
-rw-r--r-- 1 root root 51975 Jan  1  1970 accelerator-log.md
drwxr-xr-x 2 root root  4096 Jan  1  1970 catalog
drwxr-xr-x 2 root root  4096 Jan  1  1970 config
-rw-r--r-- 1 root root 10284 Jan  1  1970 mvnw
-rw-r--r-- 1 root root  6734 Jan  1  1970 mvnw.cmd
-rw-r--r-- 1 root root  2229 Jan  1  1970 pom.xml
drwxr-xr-x 4 root root  4096 Jan  1  1970 src

[hiddeco]

Happy to accept a patch in which the execution permissions are added to the default permissions if they are set for the file.

[seh]

Please be mindful of the original motivating issue in #1019, and be careful not to regress to that prior behavior.

[hiddeco]

Regression should not be an issue if we write any file that has execution permissions to 0744, which includes write permissions.