Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [flytekit][mypy] Fix Incompatible types #1427

Closed
pingsutw opened this issue Sep 3, 2021 · 0 comments
Closed

[BUG] [flytekit][mypy] Fix Incompatible types #1427

pingsutw opened this issue Sep 3, 2021 · 0 comments
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue

Comments

@pingsutw
Copy link
Member

pingsutw commented Sep 3, 2021

Describe the bug
Related to #1030
Fix mypy errors like "Incompatible types ..."

plugins/flytekit-greatexpectations/flytekitplugins/great_expectations/schema.py:54: error: Incompatible types in assignment (expression has type "None", variable has type "BatchRequestConfig")
plugins/flytekit-greatexpectations/flytekitplugins/great_expectations/schema.py:70: error: Incompatible return value type (got "Tuple[Type[str], GreatExpectationsFlyteConfig]", expected "Tuple[Type[Any], Type[GreatExpectationsFlyteConfig]]")
plugins/flytekit-greatexpectations/flytekitplugins/great_expectations/schema.py:84: error: Incompatible return value type (got "Tuple[Type[Any], GreatExpectationsFlyteConfig]", expected "Tuple[Type[Any], Type[GreatExpectationsFlyteConfig]]")
plugins/flytekit-greatexpectations/flytekitplugins/great_expectations/schema.py:325: error: Incompatible return value type (got "str", expected "GreatExpectationsType")

Expected behavior
Should pass the mypy checks.

[Optional] Additional context
To Reproduce
Steps to reproduce the behavior:

  1. make test | grep "Incompatible"

Screenshots
If applicable, add screenshots to help explain your problem.

@pingsutw pingsutw added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers bugSquash-Cascade labels Sep 3, 2021
@pingsutw pingsutw self-assigned this Sep 3, 2021
@wild-endeavor wild-endeavor added the flytekit FlyteKit Python related issue label Sep 7, 2021
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

3 participants