Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [flytekit][mypy] Fix class name is not defined #1428

Closed
pingsutw opened this issue Sep 3, 2021 · 1 comment
Closed

[BUG] [flytekit][mypy] Fix class name is not defined #1428

pingsutw opened this issue Sep 3, 2021 · 1 comment
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue untriaged This issues has not yet been looked at by the Maintainers

Comments

@pingsutw
Copy link
Member

pingsutw commented Sep 3, 2021

Describe the bug
Related to #1030
Fix mypy errors like "Name "Builder" is not defined"

flytekit/core/context_manager.py:265: error: Name "TaskResolverMixin" is not defined
flytekit/core/context_manager.py:519: error: Name "Builder" is not defined
flytekit/core/context_manager.py:542: error: Name "Builder" is not defined
flytekit/core/context_manager.py:546: error: Name "Builder" is not defined
flytekit/core/context_manager.py:550: error: Name "Builder" is not defined
flytekit/core/context_manager.py:553: error: Name "Builder" is not defined
flytekit/core/context_manager.py:557: error: Name "Builder" is not defined
flytekit/types/file/file.py:353: error: Name "literal_type.blob.format" is not defined
flytekit/types/directory/types.py:293: error: Name "literal_type.blob.format" is not defined
tests/flytekit/unit/core/test_flyte_file.py:35: error: Name "txt" is not defined
tests/flytekit/unit/core/test_flyte_file.py:42: error: Name "txt" is not defined

Expected behavior
Should pass the mypy checks.

[Optional] Additional context
To Reproduce
Steps to reproduce the behavior:

  1. make test | grep "not defined"

Screenshots
If applicable, add screenshots to help explain your problem.

@pingsutw pingsutw added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers bugSquash-Cascade labels Sep 3, 2021
@mayitbeegh mayitbeegh self-assigned this Sep 7, 2021
@wild-endeavor wild-endeavor added the flytekit FlyteKit Python related issue label Sep 7, 2021
@mayitbeegh
Copy link
Contributor

Fixed in flyteorg/flytekit#645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

3 participants